Oddbean new post about | logout
 inefficiencies potentially introduced in v0.34.0

FYI i needed to increase the timeout during tests for client.get_events_of from 500ms to 1000ms.
also, when running tests locally, a broader set of tests are intermittently failing as part of the upgrade.
Thanks for the update though! 
 With which `EventSource`? 
 Relay 
 How many relays are you using? Only 1 or more? 
 Just one:
```rust

fn get_first_proposal_event_id() -> Result<nostr::EventId> {
    // get proposal id of first
    let client = Client::default();
    Handle::current().block_on(client.add_relay("ws://localhost:8055"))?;
    Handle::current().block_on(client.connect_relay("ws://localhost:8055"))?;
    let proposals = Handle::current().block_on(client.get_events_of(
        vec![
        nostr::Filter::default()
            .kind(nostr::Kind::GitPatch)
            .custom_tag(
                nostr::SingleLetterTag::lowercase(nostr::Alphabet::T),
                vec!["root"],
            ),
    ],
        nostr_sdk::EventSource::relays(Some(Duration::from_millis(1000))),
    ))?;
    Handle::current().block_on(client.disconnect())?;

    let proposal_1_id = proposals
        .iter()
        .find(|e| {
            e.tags
                .iter()
                .any(|t| t.as_vec()[1].eq(&FEATURE_BRANCH_NAME_1))
        })
        .unwrap()
        .id;
    Ok(proposal_1_id)
}
``` 
 Can you try this commit? 

5094b373643f1629e435a5d09709d395bb5825e6 
 yes that works with the previous 500ms timeout. 
 Ok, I'm going to publish the patch 
 Thanks. I'm now using it. 
 It gets triggered in ngit intergration test module list::when_latest_revision_rebases_branch

So those tests endlessly run with a timeout of 500ms under v0.34.0 so I bumped it to 1000ms.