Awesome, not it works! But it only creates a connection if I launch Amber on nostrconnect: string, if I scan or paste it it just jumps to homepage, no connection, nothing in logs. The string is the same in both cases, like this:
nostrconnect://cf22596e3e6909d318a1da9b064da70b20b3ab36f2862d38e48c665cbd4e05fe?metadata=%7B%22name%22%3A%22nostr.band%22%2C%22url%22%3A%22https%3A%2F%2Fnostr.band%2F%3Fq%3Damber%2Bpush%2Bserver%22%2C%22icon%22%3A%22https%3A%2F%2Fnostr.band%2Ffavicon.ico%22%2C%22perms%22%3A%22sign_event%3A1985%2Csign_event%3A3%2Csign_event%3A30000%22%7D
Typo: ...noW it works...
Also can't zap you (
I think GitHub pages was not working
Try the 1.3.4 version
The split logic I was using was not working because of the q= in the url
I see, I'll try to debug this when I get home