Hey nostr:nprofile1qqswuyd9ml6qcxd92h6pleptfrcqucvvjy39vg4wx7mv9wm8kakyujgpypmhxue69uhkx6r0wf6hxtndd94k2erfd3nk2u3wvdhk6w35xs6z7qgwwaehxw309ahx7uewd3hkctcpypmhxue69uhkummnw3ezuetfde6kuer6wasku7nfvuh8xurpvdjj7a0nq40 during our testing, did you get OK messages from nip17 giftwraps on auth.nostr1.com? Vitor says amethyst isn't getting em.. but I'm pretty sure I'm sending em.. 🤔
I don't remember. I could put a giftwrap there and check, I think I'll need to write some code for that though.
Does your relay tester test for stuff like this? Man, ya I am struggle with this, I keep trying clients but not many have this auth. Afaik I'm the only one to opensource a nip42 proxy with all this DM protection stuff..
Yea run my relay tester. I'm writing the tool to create and post the giftwrap from the command line, that will be here shortly.
Ok I'm getting an error when I post a giftwrap. First, it is giving me AUTH twice (not an error but odd) then it appears to be sending false, but as a string.
Hmm ok, maybe I screwed up the false thing.. remember I 'fixed' that so it would send false to any events pre-auth..
It sends a new auth each time it gets a non-auth response (like event or request) as per the spec.. so then clients usually send back multiple responses .. 🤦♂️ afaik that's the norm..
it should only do that once for each new socket connection, which should stay open for multiple requests - this depends on how the client is written though would make life a lot easier if the relay also had a multiplexed socket, one auth, many client worker threads no problem
The spec said send false or close and another auth challenge, unless I read it wrong. The very first thing I send is auth but clients usually connect and send before checking.. I could modify to just do one auth challenge ya..
send ["OK",false,"auth-required: blah"] should be enough, i forget exactly, but the client has to expect that and queue the request to send it out after doing the auth and getting the OK true i forget how the CLOSE envelope plays into it, but i do know that replicatr does it correctly, lemme dig it up... no, it's CLOSED envelope: https://github.com/Hubmakerlabs/replicatr/blob/main/app/auth.go and then after that you send the AUTH envelope with the challenge to the client and here is my client side code, this shoud help the client devs a bit at least: this is a simple auth tester: https://github.com/Hubmakerlabs/replicatr/blob/main/cmd/authr/authr.go this shows how it's used in a client (this one can auth to two relays and pull from one and push to the other): https://github.com/Hubmakerlabs/replicatr/blob/main/cmd/ingestr/app/ingest.go of course nobody pays attention to me, but i've actually written both sides of it, fiatjaf wrote some fragments of parts of it but i wasn't able to find anything that actually demonstrated how to string it together yes, this works with coracle btw on the client side hell, replicatr works perfectly as a relay except after about 24 hours it has some weird resource leak that eats CPU that's why it isn't in production
if you can find it and fix it i'll pay a reasonable amount of sats for doing it, it's embarrassing that i couldn't find that bastard thing... it's instrumented with profiling and runtime configuration settings and everything, drove me nuts
most likely i made the bug, also, but probably thanks to how convoluted fiatjaf's goroutine spawning is written
I am pretty sure auth is working I tested with a bunch of clients and use it with ndk, but the mystery of the giftwraps. I tried your tool, it has mleku.net deps still lingering I can't build it.
ah crap, i better fix that tomorrow not sure why you aren't getting them from the go module proxy cache tho yeah, tomorrow... i'm currently working on a count encoder that appends to a buffer you pass it so you can reuse the buffer
i'm getting that done now btw, just running tests after moving all the required content into place so it's a monorepo then i'll check that everything in cmd and the root build correctly also, won't be long (one of the tests runs for a while haha)
it's done btw, you should now be able to do like go install github.com/Hubmakerlabs/replicatr/cmd/ingestr and have it pull and build it, anyhow, it's there, i needed to fix it, i forgot it was totally broken
go install github.com/Hubmakerlabs/replicatr/cmd/ingestr@latest lol
go install github.com/Hubmakerlabs/replicatr/cmd/ingestr@v1.2.17 better still, that is the actually what i just built now me@iox:/src/github.com/Hubmakerlabs/replicatr$ ingestr Usage: ingestr [--nsec NSEC] [--since SINCE] [--limit LIMIT] [--interval INTERVAL] [--pause PAUSE] [--follows FOLLOWS] DOWNLOADRELAY UPLOADRELAY error: downloadrelay is required
Thanks man, ya I found my bug. String instead of bool. 🤦♂️
Yeah it isn't a problem. I just noticed it in the output.
Yeah, false is correct since I hadn't AUTHed yet, but false as a string crashes my testing client which cannot deserialize the json.
Ah, so maybe my false response is malformed then? I will re-read the nip again..
I am basically hand crafting these responses according to the nip examples
see my response, i wrote all this stuff, i know it works, it auths on nostrudel and coracle, just the damn resource bug it's at https://github.com/Hubmakerlabs/replicatr in cmd/ingestr for client side, anyway, just check my other note here: nostr:nevent1qvzqqqqqqypzqnyqqft6tz9g9pyaqjvp0s4a4tvcfvj6gkke7mddvmj86w68uwe0qqszeyrlj2mcvggjzp2y9np52eyq4yjxu09wzzyret7zvqxskflcthsv9prp8
I will need to fire up mitmproxy to see the traffic on the wire. As far as i can tell, the code is supposed to be sending false like this falseString := fmt.Sprintf(`["OK","%s","false","auth-required: you must auth"]`, event.ID)
Of course, my own client doesn't send an event pre auth, so I would need one that does and inspect it's traffic. 😂 also nostr:nprofile1qqsyvrp9u6p0mfur9dfdru3d853tx9mdjuhkphxuxgfwmryja7zsvhqpzamhxue69uhhv6t5daezumn0wd68yvfwvdhk6tcpz9mhxue69uhkummnw3ezuamfdejj7qgwwaehxw309ahx7uewd3hkctcscpyug said he may have found a problem in amethyst where it wasn't retrying the event when it received a pre-auth "false". So... I still will try your tool at your leisure man, thanks for the halp! 💎
https://github.com/Hubmakerlabs/replicatr this should build for you now, i pulled in all those dependencies and made it a monorepo was pretty funny running it again... had all the configurations and a database already sitting on my disk and just fires right up anyhow, please reply if you get any errors with it now, i'm pretty sure i didn't exclude anything in the allowlist .gitignore but i buggered up the precomps in my revised embed version elsewhere (yeah, this whole mess happened because i kept getting git bugs and gave up self hosting after i had mleku.net/reponame as i wanted using legit but gd fkn git buggerization, haven't heard from the legit dev yet about a fix on it i filed an issue)
Ohhhh dude, I get what you mean now.. the relay tester wants a Boolean and I am sending a string 🤦♂️🤦♂️🤦♂️ big whoops, I forgot json had boolean. Ok I will fix this.
Hey Mike, ya the relay tester was right. I deployed a fix to change the string to bool and the auth test proceeded. Whew, relay tester ftw!! 💎
did you verify that it is a "CLOSED" envelope its supposed to send first then "AUTH" with challenge after? (and expect an AUTH with signed event containing challenge... in the content field??? i think? no, i think in the tag after "challenge")
https://github.com/nostr-protocol/nips/blob/master/42.md#protocol-flow yeah, that's the info there anyhow
Did you run my https://github.com/mikedilger/relay-tester or are you referring to me as your "relay tester"? 😂
Yes I ran it lmao!!! 😂😎👨💻