yeah i just bumped into it yesterday for the first time and most of it is really muddling domains, and not using existing data
i already have an access whitelist control that simply uses protocol follow and mute events to construct the list for access control, for example, there is no need to have a second database for this, you see what i mean?
IP blocking is a different thing but again it would be simpler to just make a shim that filters this access and configure it through its own interface, this is another API call i see in there, again, it doesn't honestly belong in the API of a relay because it can be more efficiently done at the network layer, same as access control can be done using nostr's event types