Oddbean new post about | logout
 is it rude to approve a PR on Github but ask a bunch of questions and/or make some suggestions? I feel like this is my default PR response at work and I can’t tell if it’s a good or passive-aggressive or what. I think I’ve hit “Request changes” like four times in my entire life. (when I hit approve, I do sincerely mean that I’m okay with it getting merged in its current state)