Just wanted to say that I appreciated @roland, @tyiu, @elsat & @jb55 working together to squash a bug that was preventing #zaps to my @Alby Lightning address from showing up on Damus. I’m back to fully self-custodial zaps again on my own node and it feels amazing. https://image.nostr.build/cc0949fb1d5d8018b109cb923b233fae343c4cdf2d59df4dd137d596e04d5823.gif
Oh i thought it was just me. Is there a writeup on what it was or how it was fixed?
Damus had dubious logic that would look for the zap request inside of a bolt11 description if it was a description invoice instead of a description hash invoice. Alby hub was creating description invoices and are not committing to the zap request. Damus did not handle this properly. I still think zap implementations should commit the zap request in the description hash, people have given up on validation of any sort except the nostrPubkey == zap pubkey. So yeah thats it in a nutshell if that makes any lick of sense.
That sucks, wish zaps had more auth too
just to mention this, this is not in Alby Hub's hands. This is a limitation of LDK, Phoenixd, also with CLN there are implementation issues and setups like LNBits have issues with that, too. https://github.com/lnurl/luds/pull/234